Adding Campaign Page Chips to Sections #1524
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Not all tests have run for this PR. Please add the |
igoychev
reviewed
Jul 31, 2023
Comment on lines
141
to
145
| <Grid container item xs={12}> | ||
| {Object.entries(chipsLabel).map(([id, label]) => ( | ||
| <CampaignDetailsChip key={id} chip={label} onClick={() => scrollToSection(id)} /> | ||
| ))} | ||
| </Grid> |
There was a problem hiding this comment.
Looks good! Just let's move them directly below the title and also let's use color=primary ot make the main blue color of the site
There was a problem hiding this comment.
I contact the ui/ux college to clarify translations and design(colors etc..)
There was a problem hiding this comment.
i think is a good starting point(with some bugs for fixing)
@swolf86
ani-kalpachka
approved these changes
Aug 9, 2023
github-actions
bot
removed
the
run tests
igoychev
requested changes
Aug 10, 2023
Merged
|
closing on behalf of #1577 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1430